[PATCH] D59450: [ValueTracking] Use ConstantRange overflow check for signed add (NFC)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 17 02:53:31 PDT 2019


nikic added a comment.

> So is it NFC (not counting the AlwaysOverflows) or not?

It is. The signed sub case wouldn't be though, as it only implements a basic sign check. At the time I wrote that I also thought that the ripple logic for signed add was more powerful than the constant range logic, but that was because I was thinking in unsigned ranges.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59450/new/

https://reviews.llvm.org/D59450





More information about the llvm-commits mailing list