[PATCH] D59450: [ValueTracking] Use ConstantRange overflow check for signed add (NFC)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

> This is still intended as NFC

https://reviews.llvm.org/rL356290

> This is NFC: <...> This is not the case for the
>  signed equivalents, so I'm only changing unsigned here.

So is it NFC (not counting the `AlwaysOverflows`) or not?



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4082
+/// domain.
+static ConstantRange unsignedConstantRangeFromKnownBits(
+    const KnownBits &Known) {
----------------
Please commit this rename directly.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4099
+  if (Known.isNegative() || Known.isNonNegative())
+    return ConstantRange(Known.One, ~Known.Zero + 1);
+
----------------
`return unsignedConstantRangeFromKnownBits(Known);`  ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59450/new/

https://reviews.llvm.org/D59450