[PATCH] D59193: [ConstantRange] Add overflow check helpers

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 10 15:15:30 PDT 2019


nikic added a reviewer: lebedev.ri.
nikic added a comment.

In D59193#1424073 <https://reviews.llvm.org/D59193#1424073>, @lebedev.ri wrote:

> What's the runtime of the current 4-bit case?


The run-times for the 4-bit checks I get on a debug build:

  [ RUN      ] ConstantRangeTest.UnsignedAddOverflowExhautive
  [       OK ] ConstantRangeTest.UnsignedAddOverflowExhautive (609 ms)
  [ RUN      ] ConstantRangeTest.UnsignedSubOverflowExhautive
  [       OK ] ConstantRangeTest.UnsignedSubOverflowExhautive (589 ms)
  [ RUN      ] ConstantRangeTest.SignedAddOverflowExhautive
  [       OK ] ConstantRangeTest.SignedAddOverflowExhautive (726 ms)
  [ RUN      ] ConstantRangeTest.SignedSubOverflowExhautive
  [       OK ] ConstantRangeTest.SignedSubOverflowExhautive (735 ms)

For 3-bit checks:

  [ RUN      ] ConstantRangeTest.UnsignedAddOverflowExhautive
  [       OK ] ConstantRangeTest.UnsignedAddOverflowExhautive (11 ms)
  [ RUN      ] ConstantRangeTest.UnsignedSubOverflowExhautive
  [       OK ] ConstantRangeTest.UnsignedSubOverflowExhautive (10 ms)
  [ RUN      ] ConstantRangeTest.SignedAddOverflowExhautive
  [       OK ] ConstantRangeTest.SignedAddOverflowExhautive (13 ms)
  [ RUN      ] ConstantRangeTest.SignedSubOverflowExhautive
  [       OK ] ConstantRangeTest.SignedSubOverflowExhautive (14 ms)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59193/new/

https://reviews.llvm.org/D59193





More information about the llvm-commits mailing list