[PATCH] D59193: [ConstantRange] Add overflow check helpers

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 10 14:52:56 PDT 2019


lebedev.ri added a comment.

In D59193#1424072 <https://reviews.llvm.org/D59193#1424072>, @nikic wrote:

> @lebedev.ri I've implemented the following code for exhaustive checking on 4-bit numbers: https://gist.github.com/nikic/3d37a4742a8685c5dd101524f928fe58 The source of truth are APInt uadd_ov and friends.


Nice, not manual hardcoding, but cross-checking.

> Is this something I should include in the patch (possibly reduced to 3-bit testing) or is this okay as a one-off test?

What's the runtime of the current 4-bit case?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59193/new/

https://reviews.llvm.org/D59193





More information about the llvm-commits mailing list