[PATCH] D59193: [ConstantRange] Add overflow check helpers

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D59193#1424074 <https://reviews.llvm.org/D59193#1424074>, @nikic wrote:

> In D59193#1424073 <https://reviews.llvm.org/D59193#1424073>, @lebedev.ri wrote:
>
> > What's the runtime of the current 4-bit case?
>
>
> The run-times for the 4-bit checks I get on a debug build:
>
>   [ RUN      ] ConstantRangeTest.UnsignedAddOverflowExhautive
>   [       OK ] ConstantRangeTest.UnsignedAddOverflowExhautive (609 ms)
>   [ RUN      ] ConstantRangeTest.UnsignedSubOverflowExhautive
>   [       OK ] ConstantRangeTest.UnsignedSubOverflowExhautive (589 ms)
>   [ RUN      ] ConstantRangeTest.SignedAddOverflowExhautive
>   [       OK ] ConstantRangeTest.SignedAddOverflowExhautive (726 ms)
>   [ RUN      ] ConstantRangeTest.SignedSubOverflowExhautive
>   [       OK ] ConstantRangeTest.SignedSubOverflowExhautive (735 ms)
>


I was expecting something like 10 sec total, that looks like nothing to me.
Please add those tests into appropriate place :)
It's not SMT, but better than nothing i suppose.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59193/new/

https://reviews.llvm.org/D59193