[PATCH] D58909: [llvm-objcopy] - Report "no zlib available" error properly when --compress-debug-sections is used.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 03:03:45 PST 2019


jhenderson added a comment.

In D58909#1418126 <https://reviews.llvm.org/D58909#1418126>, @grimar wrote:

> My reason to fix it was that I couldn't reproduce an error reported in https://bugs.llvm.org/show_bug.cgi?id=40885 on windows (with zlib off).


Yes, that's how I discovered the bug this fixes actually! I just didn't have time to dig into it and fix it, so thanks. BTW, you'll definitely need zlib in order to reproduce https://bugs.llvm.org/show_bug.cgi?id=40885.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58909/new/

https://reviews.llvm.org/D58909





More information about the llvm-commits mailing list