[PATCH] D58909: [llvm-objcopy] - Report "no zlib available" error properly when --compress-debug-sections is used.

Tue Mar 5 02:40:40 PST 2019

grimar added a comment.

In D58909#1418115 <https://reviews.llvm.org/D58909#1418115>, @jhenderson wrote:

> By the way, is this fixing https://bugs.llvm.org/show_bug.cgi?id=40886? I think it does for me.

Yes, I think so too. Since now it will emit an error saying zlib isn't available. 
In the description of this patch, I wrote "sections silently remain uncompressed in the output" but I just rechecked it
and they are stripped out for me too. Perhaps I looked at the wrong console window, I am not sure. I'll fix the description.

My reason to fix it was that I couldn't reproduce an error reported in https://bugs.llvm.org/show_bug.cgi?id=40885 on windows (with zlib off).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58909/new/

https://reviews.llvm.org/D58909