[PATCH] D58909: [llvm-objcopy] - Report "no zlib available" error properly when --compress-debug-sections is used.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 03:33:11 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL355391: [llvm-objcopy] - Report "no zlib available" error properly when --compress… (authored by grimar, committed by ).
Herald added a project: LLVM.

Changed prior to commit:
  https://reviews.llvm.org/D58909?vs=189154&id=189293#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58909/new/

https://reviews.llvm.org/D58909

Files:
  llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp


Index: llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp
===================================================================
--- llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp
+++ llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp
@@ -476,11 +476,11 @@
             InputArgs.getLastArgValue(OBJCOPY_compress_debug_sections_eq)
                 .str()
                 .c_str());
-      if (!zlib::isAvailable())
-        return createStringError(
-            errc::invalid_argument,
-            "LLVM was not compiled with LLVM_ENABLE_ZLIB: can not compress");
     }
+    if (!zlib::isAvailable())
+      return createStringError(
+          errc::invalid_argument,
+          "LLVM was not compiled with LLVM_ENABLE_ZLIB: can not compress");
   }
 
   Config.AddGnuDebugLink = InputArgs.getLastArgValue(OBJCOPY_add_gnu_debuglink);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58909.189293.patch
Type: text/x-patch
Size: 823 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190305/969c80bc/attachment.bin>


More information about the llvm-commits mailing list