[PATCH] D58899: [CodeGen] Prepare for introduction of v3 and v5 MVTs

[Tim Renouf via Phabricator via llvm-commits]

tpr marked 3 inline comments as done.
tpr added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:12153
   unsigned NumLanes = Op.getValueType().getVectorNumElements();
-  if (FloatBits != 32 || IntBits > 32 || NumLanes > 4) {
+  if (FloatBits != 32 || IntBits > 32 || NumLanes > 4 || NumLanes == 3) {
     // These instructions only exist converting from f32 to i32. We can handle
----------------
arsenm wrote:
> Combine the last 2 checks into NumLanes >= 3
That won't work -- it needs to be true for ==3 and >4, but not for ==4.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58899/new/

https://reviews.llvm.org/D58899