[PATCH] D58899: [CodeGen] Prepare for introduction of v3 and v5 MVTs

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 13:20:23 PST 2019


efriedma added a comment.

The general idea makes sense, I think.



================
Comment at: lib/CodeGen/TargetLoweringBase.cpp:746
+  if (VT.isSimple() &&
+      (!VT.isVector() || VT.isPow2VectorType() || isTypeLegal(VT))) {
     MVT SVT = VT.getSimpleVT();
----------------
The reason we're checking for isSimple() here is precisely so that we can perform a lookup in the TransformToType array.  If we need a couple extra lines of code to handle TypeWidenVector, we should just add them (and maybe refactor the code so it doesn't repeat itself so much).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58899/new/

https://reviews.llvm.org/D58899





More information about the llvm-commits mailing list