[PATCH] D52138: [Thumb] Add some integer abs testcases for different typesizes.

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

>From what I can tell, t.p.northover was added as a blocking reviewer, he didn't block this patch.

I agree with RKSimon, you can remove the odd "count" check and just use the update script.



================
Comment at: test/CodeGen/Thumb/iabs.ll:3
+; RUN: llvm-objdump -disassemble -arch-name=thumb %t.o | FileCheck  --check-prefix=COUNT %s
+; RUN: llc < %s -mtriple=thumb-unknown-unknown | FileCheck %s
 
----------------
RKSimon wrote:
> RKSimon wrote:
> > Instead of the counts, just running llc and checking the full codegen would be a lot cleaner.
> > 
> > I don't think the update_llc_test_checks script supports thumb triples but that'd be even easier.....
> Drop the llvm-objdump run - we can get everything we need (full instruction codegen) from the llc - that checks we have the right #instructions.
Yep, I agree. Maybe change the triple to thumbv6m-none-eabi too? Then just run update_llc_test_checks.py on it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52138/new/

https://reviews.llvm.org/D52138