[PATCH] D52138: [Thumb] Add some integer abs testcases for different typesizes.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: test/CodeGen/Thumb/iabs.ll:3
+; RUN: llvm-objdump -disassemble -arch-name=thumb %t.o | FileCheck  --check-prefix=COUNT %s
+; RUN: llc < %s -mtriple=thumb-unknown-unknown | FileCheck %s
 
----------------
RKSimon wrote:
> Instead of the counts, just running llc and checking the full codegen would be a lot cleaner.
> 
> I don't think the update_llc_test_checks script supports thumb triples but that'd be even easier.....
Drop the llvm-objdump run - we can get everything we need (full instruction codegen) from the llc - that checks we have the right #instructions.


================
Comment at: test/CodeGen/Thumb/iabs.ll:20
+; COUNT-CHECK-NOT: 8:
 }
 
----------------
This test is just a copy of test_i32 - lets keep test_i32 and get rid of this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52138/new/

https://reviews.llvm.org/D52138