[PATCH] D58427: Fix checking for rpc/xdr.h

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> The API on FreeBSD clearly calls for rpc/types.h: https://www.freebsd.org/cgi/man.cgi?query=xdr&sektion=3&apropos=0&manpath=freebsd .
> 
> By convention, FreeBSD splits up the types from the API declarations to avoid header pollution. This is why `sys/socket.h` (for instance) needing `sys/types.h` is more necessary on FreeBSD than Linux.

Thanks for the explanation (to prevent header pollution), but for this particular case, I'm still not sure why https://github.com/freebsd/freebsd/blob/master/sys/rpc/xdr.h cannot include `rpc/types.h`. The file directly references `TRUE` `bool_t`. If it didn't, it would be justified to not include `rpc/includes.h`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58427/new/

https://reviews.llvm.org/D58427