[PATCH] D58427: Fix checking for rpc/xdr.h

Fri Feb 22 01:39:41 PST 2019

ngie added a comment.

In D58427#1405336 <https://reviews.llvm.org/D58427#1405336>, @MaskRay wrote:

> I think the fix is correct, but is there any patch fixing these `rpc/*.h` headers on FreeBSD's side (for `bool_t`)? https://svnweb.freebsd.org/base/head/include/rpc/xdr.h

The API on FreeBSD clearly calls for rpc/types.h: https://www.freebsd.org/cgi/man.cgi?query=xdr&sektion=3&apropos=0&manpath=freebsd .

By convention, FreeBSD splits up the types from the API declarations to avoid header pollution. This is why `sys/socket.h` (for instance) needing `sys/types.h` is more necessary on FreeBSD than Linux.

> glibc and Solaris-based platforms shouldn't be affected by this change, but what does bionic do? Does it provide `rpc/*.h`?

Bionic libc doesn't currently include these headers. However, if it did, it would be affected by this on FreeBSD.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58427/new/

https://reviews.llvm.org/D58427