[PATCH] D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:237
   /// The name of the file to which the backend should save YAML optimization
   /// records.
+  std::string RecordFile;
----------------
Should this comment be updated as well? 


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:238
   /// records.
-  std::string OptRecordFile;
+  std::string RecordFile;
 
----------------
fhahn wrote:
> Maybe RemarkRecordFile or something? Just RecordFile seems a bit unspecific to me. Also the comment above still refers to optimization records.
Or maybe `RemarkFile` for consistency with `RemarkPattern` below. 


================
Comment at: llvm/include/llvm-c/Remarks.h:34
 
-#define OPT_REMARKS_API_VERSION 0
+#define REMARKS_API_VERSION 0
 
----------------
Are you sure this has no users? It's my understanding that we cannot break APIs in the C interface. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58535/new/

https://reviews.llvm.org/D58535