[PATCH] D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:238
   /// records.
-  std::string OptRecordFile;
+  std::string RecordFile;
 
----------------
Maybe RemarkRecordFile or something? Just RecordFile seems a bit unspecific to me. Also the comment above still refers to optimization records.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:245
   /// -Rpass=regexp flag.
   std::shared_ptr<llvm::Regex> OptimizationRemarkPattern;
 
----------------
Drop Optimization here?


================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:268
 
-      std::unique_ptr<llvm::ToolOutputFile> OptRecordFile;
-      if (!CodeGenOpts.OptRecordFile.empty()) {
+      std::unique_ptr<llvm::ToolOutputFile> RecordFile;
+      if (!CodeGenOpts.RecordFile.empty()) {
----------------
Same as above,  maybe RemarkRecordFile?


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:463
+  // remarks flags.
   if (Args.hasFlag(options::OPT_fsave_optimization_record,
                    options::OPT_fno_save_optimization_record, false)) {
----------------
Still refers to optimization record? 


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1213
 
-  Opts.OptRecordFile = Args.getLastArgValue(OPT_opt_record_file);
-  if (!Opts.OptRecordFile.empty())
+  Opts.RecordFile = Args.getLastArgValue(OPT_opt_record_file);
+  if (!Opts.RecordFile.empty())
----------------
option still named OPT_opt_record_file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58535/new/

https://reviews.llvm.org/D58535