[PATCH] D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 10:50:49 PST 2019


paquette added inline comments.


================
Comment at: llvm/unittests/Remarks/RemarksParsingTest.cpp:278
+      "expected a value of scalar type."));
+  // Not a integer line in debug loc.
+  EXPECT_TRUE(parseExpectError(
----------------
What happens if you give a negative line or column number?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58535/new/

https://reviews.llvm.org/D58535





More information about the llvm-commits mailing list