[PATCH] D58348: [AArch64] Fix for bug 35094 atomicrmw on Armv8.1-A+lse

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 05:08:36 PST 2019


john.brawn added inline comments.


================
Comment at: lib/Target/AArch64/AArch64DeadRegisterDefinitionsPass.cpp:73
+// (DMB LD) once the zero register is used.
+static bool atomicReadDroppedOnZero(unsigned Opcode) {
+  switch (Opcode) {
----------------
It doesn't especially matter, as it'll already get caught by atomicBarrierDroppedOnZero, but the acquire variants of these instructions (LDADDAW etc.) also aren't counted as performing a read when the destination register is zero.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58348/new/

https://reviews.llvm.org/D58348





More information about the llvm-commits mailing list