[PATCH] D58348: [AArch64] Fix for bug 35094 atomicrmw on Armv8.1-A+lse

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 14:32:34 PST 2019


efriedma added a comment.

> Is that up for debate in case this is an edge case that is unlikely to be hit?

When it comes to the atomics in general, it's important to allow people to write code with the same performance characteristics as hand-written assembly, or else we force people will go around the compiler using inline asm.  But the performance impact here should be basically zero for code that doesn't use an acquire fence, I think, so it shouldn't be an issue here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58348/new/

https://reviews.llvm.org/D58348





More information about the llvm-commits mailing list