[PATCH] D58406: Fix IR/Analysis layering issue in OptBisect
Richard Trieu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 20 20:53:34 PST 2019
rtrieu added a comment.
Last time, this was brought up, passing strings was deemed too expensive since it would cause a string to be created every time:
http://lists.llvm.org/pipermail/llvm-dev/2018-March/122032.html
There's a difference between getting the pass name and the IR unit name. Pass names are hard-coded string literals which can be cheaply referred to by a StringRef. IR units need to create a new string with the description (except Loop and Region, which don't have interesting descriptions yet.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58406/new/
https://reviews.llvm.org/D58406
More information about the llvm-commits
mailing list