[PATCH] D58406: Fix IR/Analysis layering issue in OptBisect

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 10:08:52 PST 2019


fedor.sergeev added a comment.

In D58406#1404292 <https://reviews.llvm.org/D58406#1404292>, @philip.pfaffe wrote:

> Keep in mind that for the new PM we're talking about an API that's much more powerful, because it's designed for arbitrary hooks. 
>  OptBisect doesn't need that necessarily. I'm in favor of passing the strings instead.


Yep, thats true.
Was just pointing out that new PM might benefit from generalization, if anybody decides to do it ;)

I'm fine with passing the strings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58406/new/

https://reviews.llvm.org/D58406





More information about the llvm-commits mailing list