[llvm-dev] Opt Bisect layering

[Yevgeny Rouban via llvm-dev]

Andrew,

I would not make the caller pass the description of the IR unit. That is
because it would result in the description generated every time even if
OptBisect is disabled. Description generation is not very chip.
Thinking on the OptBisect extension, I believe passing the units are the
right choice because OptPassGates may use them to make pass skipping
decisions.

-Yevgeny Rouban
-----------------------------------------------------------

*From:* llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org
<llvm-dev-bounces at lists.llvm.org>] *On Behalf Of *Kaylor, Andrew via llvm-
dev
*Sent:* Thursday, March 22, 2018 3:52 AM
*To:* David Blaikie <dblaikie at gmail.com>; llvm-dev <llvm-dev at lists.llvm.org>;
Friedman, Eli <efriedma at codeaurora.org>
*Subject:* Re: [llvm-dev] Opt Bisect layering



There is a patch under review right now from someone who wants to provide a
mechanism to replace OptBisect as the pass gate keeping mechanism.



https://reviews.llvm.org/D44464



Possibly we could take this opportunity to move OptBisect to a different
layer, though I don’t know where else it would belong.



The other possibility is that we could have the caller pass in a
description instead of a pointer to the pass and the IR unit. OptBisect
isn’t doing anything with them other than building a string for output.



-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180322/207434b8/attachment.html>