[PATCH] D58093: [CMake][runtimes] Use variables rather than ":" delimiters
    Shoaib Meenai via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Feb 15 14:54:09 PST 2019
    
    
  
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/runtimes/CMakeLists.txt:394
+      set(install-${component}-${name} ${component})
+      list(APPEND ${name}_extra_targets install-${component}-${name} ${component}-${name})
     endforeach()
----------------
Super nit part 2: switch the append order around to match the `set` command order?
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58093/new/
https://reviews.llvm.org/D58093
    
    
More information about the llvm-commits
mailing list