[PATCH] D58093: [CMake][runtimes] Use variables rather than ":" delimiters
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 14:24:48 PST 2019
phosek added inline comments.
================
Comment at: llvm/runtimes/CMakeLists.txt:394
+ set(${component}-${name} ${component})
+ list(APPEND ${name}_extra_targets ${target_name}-install-${component} ${target_name}-${component})
endforeach()
----------------
smeenai wrote:
> I'm confused. Should this be something like the following instead?
>
> list(APPEND ${name}_extra_targets install-${component}-${name} ${component}-${name})
Yes, this is a copy-pasta error.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58093/new/
https://reviews.llvm.org/D58093
More information about the llvm-commits
mailing list