[PATCH] D58093: [CMake][runtimes] Use variables rather than ":" delimiters

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 20:02:46 PST 2019


phosek updated this revision to Diff 187125.
phosek marked an inline comment as done.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58093/new/

https://reviews.llvm.org/D58093

Files:
  llvm/runtimes/CMakeLists.txt


Index: llvm/runtimes/CMakeLists.txt
===================================================================
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -389,11 +389,9 @@
     endforeach()
 
     foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
-      if(NOT "${target_name}:${target_name}-${component}" IN_LIST extra_targets)
-        list(APPEND ${name}_extra_targets
-          "${target_name}:${target_name}-${component}"
-          "${target_name}:${target_name}-install-${component}")
-      endif()
+      set(${component}-${name} ${component})
+      set(install-${component}-${name} ${component})
+      list(APPEND ${name}_extra_targets ${component}-${name} install-${component}-${name})
     endforeach()
 
     if(LLVM_INCLUDE_TESTS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58093.187125.patch
Type: text/x-patch
Size: 776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190216/99da1a7e/attachment.bin>


More information about the llvm-commits mailing list