[PATCH] D58138: [GlobalISel][NFC] Gardening: Factor out more intrinsics into simple intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 11:18:46 PST 2019


arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:859
+  ArrayRef<unsigned> DstRegs = getOrCreateVRegs(CI);
+  SmallVector<llvm::DstOp, 4> DstOps(DstRegs.begin(), DstRegs.end());
 
----------------
I don't think you need to copy the ArrayRef to a SmallVector, you should be able to use the ArrayRef as is


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58138/new/

https://reviews.llvm.org/D58138





More information about the llvm-commits mailing list