[PATCH] D58138: [GlobalISel][NFC] Gardening: Factor out more intrinsics into simple intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:859
+  ArrayRef<unsigned> DstRegs = getOrCreateVRegs(CI);
+  SmallVector<llvm::DstOp, 4> DstOps(DstRegs.begin(), DstRegs.end());
 
----------------
arsenm wrote:
> I don't think you need to copy the ArrayRef to a SmallVector, you should be able to use the ArrayRef as is
Actually since this is DstOp, and not unsigned, you do. Maybe this should be moved as an overload in MachineIRBuilder though. You also don't need the llvm::


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58138/new/

https://reviews.llvm.org/D58138