[PATCH] D58066: [MCA][Scheduler] Use latency information to further classify busy instructions.

[Matt Davis via Phabricator via llvm-commits]

mattd added a comment.

LGTM.  I had a few suggestions but nothing looks wrong to me.



================
Comment at: lib/MCA/HardwareUnits/Scheduler.cpp:99
   // instructions to the ReadySet and notify the caller that those are ready.
   if (HasDependentUsers)
+    if (promoteToPendingSet())
----------------
Suggestion:  `if (HasDependentUsers && promoteToPendingSet()) ...`


================
Comment at: lib/MCA/HardwareUnits/Scheduler.cpp:143
+  // pending set if operands are all ready.
+  unsigned RemovedElements = 0;
+  for (auto I = WaitSet.begin(), E = WaitSet.end(); I != E;) {
----------------
Suggestion: s/RemovedElements/PromotedElements/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58066/new/

https://reviews.llvm.org/D58066