[PATCH] D57821: [LLD][ELF] - Set DF_STATIC_TLS flag for X64 target

[Rui Ueyama via llvm-commits]

On Wed, Feb 6, 2019 at 11:07 AM Peter Collingbourne via Phabricator <
reviews at reviews.llvm.org> wrote:

> pcc added inline comments.
>
>
> ================
> Comment at: ELF/Arch/X86_64.cpp:84
>                                   const uint8_t *Loc) const {
> +  if (Type == R_X86_64_GOTTPOFF)
> +    Config->HasStaticTlsModel = true;
> ----------------
> Should this be done in `scanRelocs`? Then I believe that
> `HasStaticTlsModel` would not need to be atomic.
>

Maybe. I don't have a strong preference but it's perhaps worth a try.


>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57821/new/
>
> https://reviews.llvm.org/D57821
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190206/7e7c22d4/attachment.html>