[PATCH] D57821: [LLD][ELF] - Set DF_STATIC_TLS flag for X64 target

Wed Feb 6 13:56:33 PST 2019

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: ELF/Arch/X86_64.cpp:84
                                  const uint8_t *Loc) const {
+  if (Type == R_X86_64_GOTTPOFF)
+    Config->HasStaticTlsModel = true;
----------------
pcc wrote:
> Should this be done in `scanRelocs`? Then I believe that `HasStaticTlsModel` would not need to be atomic.
I suggested this in comments for D57749:
https://reviews.llvm.org/D57749?id=185294#inline-511460

Rui seems to prefer to have atomic. I have no strong feeling about what is better.
Both approaches have own pros and cons.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57821/new/

https://reviews.llvm.org/D57821