<div dir="ltr"><div dir="ltr">On Wed, Feb 6, 2019 at 11:07 AM Peter Collingbourne via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">pcc added inline comments.<br>
<br>
<br>
================<br>
Comment at: ELF/Arch/X86_64.cpp:84<br>
                                  const uint8_t *Loc) const {<br>
+  if (Type == R_X86_64_GOTTPOFF)<br>
+    Config->HasStaticTlsModel = true;<br>
----------------<br>
Should this be done in `scanRelocs`? Then I believe that `HasStaticTlsModel` would not need to be atomic.<br></blockquote><div><br></div><div>Maybe. I don't have a strong preference but it's perhaps worth a try.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D57821/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57821/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D57821" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57821</a><br>
<br>
<br>
<br>
</blockquote></div></div>