[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

Mon Feb 4 19:45:44 PST 2019

craig.topper marked an inline comment as done and an inline comment as not done.
craig.topper added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:923-925
+    // insert a computation after it without breaking the edge. Same for callbr.
+    if (isa<InvokeInst>(InVal) || isa<CallBrInst>(InVal))
+      if (cast<Instruction>(InVal)->getParent() == NonConstBB)
----------------
craig.topper wrote:
> chandlerc wrote:
> > May also be a tiny bit clearer by using terminator based terminology and APIs.
> I'm just going to remove this change because it would require a CallBrInst that returned a value, but we don't support that right now.
Oops I meant to remove this comment. I've now fixed the code to use terminator terminology and apis

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765