[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked an inline comment as done and an inline comment as not done.
craig.topper added inline comments.


================
Comment at: include/llvm/Bitcode/LLVMBitCodes.h:477
+  FUNC_CODE_INST_INVOKE = 13,  // INVOKE:     [attr, fnty, op0,op1, ...]
+  FUNC_CODE_INST_CALLBR = 14,  // CALLBR:     [attr, cc, norm, transfs,
+                               //              fnty, fnid, args...]
----------------
craig.topper wrote:
> Can this use the 14 or does it need a new number? Not sure how holes get created here.
@chandlerc do you know the answer to the question I left here?


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:923-925
+    // insert a computation after it without breaking the edge. Same for callbr.
+    if (isa<InvokeInst>(InVal) || isa<CallBrInst>(InVal))
+      if (cast<Instruction>(InVal)->getParent() == NonConstBB)
----------------
chandlerc wrote:
> May also be a tiny bit clearer by using terminator based terminology and APIs.
I'm just going to remove this change because it would require a CallBrInst that returned a value, but we don't support that right now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765