[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: include/llvm/Bitcode/LLVMBitCodes.h:477
+  FUNC_CODE_INST_INVOKE = 13,  // INVOKE:     [attr, fnty, op0,op1, ...]
+  FUNC_CODE_INST_CALLBR = 14,  // CALLBR:     [attr, cc, norm, transfs,
+                               //              fnty, fnid, args...]
----------------
craig.topper wrote:
> craig.topper wrote:
> > Can this use the 14 or does it need a new number? Not sure how holes get created here.
> @chandlerc do you know the answer to the question I left here?
Not directly... But I think I can explain how to answer it.

Does any version of LLVM bitcode that we still support reading use 14? If so, then we need to leave it alone. If not, I think you can take it.

But maybe good to double check w/ someone who has thought more fully about bitcode backwards compat.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765