[PATCH] D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping

[James Henderson via Phabricator via llvm-commits]

jhenderson added a subscriber: khemant.
jhenderson added a comment.

In D57700#1384760 <https://reviews.llvm.org/D57700#1384760>, @grimar wrote:

> In D57700#1384747 <https://reviews.llvm.org/D57700#1384747>, @jhenderson wrote:
>
> > I'm happy with this, but since I was the one who suggested this offline, and I'm aware that there might be some reluctance to accept it from elsewhere, I'd like some other people's comments on it.
>
>
> My main concern is: is it ok we change the GNU style output?
>
> Actually, I am confused and wonder why we have LLVM and GNU styles first of all. 
>  I would understand if we would have GNU style that would try to be 1:1 to GNU and we would have LLVM style that would be an extension/restyling.


Taken from D14128 <https://reviews.llvm.org/D14128>, which was the review to introduce the new style:

> Hello Davide,
>  The present format is good enough to convey the information. It is however not sufficient or sometimes difficult for present users of GNU tools (which are quite ubiquitous) to make a
>  switch as it is complete redesign of the post processing tools they may have based on.
> 
> -Hemant

It's not immediately clear from the original introduction of GNU style whether complete output identity was the original goal, or just similarity. Similarly, it's not clear from my previously attempt to gather information as to users expectations. I've subscribed @khemant in case he's got any further comments, since he made the original change. My reading of rL260430 <https://reviews.llvm.org/rL260430> which commits it is that it is intended to be //like// GNU readelf, but doesn't necessarily have to be identical. I'm open to further discussion on this (and I actually have a BoF on this subject at the next Euro LLVM, but that's still a couple of months away).

> This patch changes GNU style of printSectionMapping. It makes me think we want LLVM style implementation of `printSectionMapping` instead maybe?

Certainly at some point we should add this to LLVM style, but I don't think it means we can't have it for GNU style too necessarily.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57700/new/

https://reviews.llvm.org/D57700