[PATCH] D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 09:40:43 PST 2019


mattd marked an inline comment as done.
mattd added a comment.

In D57700#1384786 <https://reviews.llvm.org/D57700#1384786>, @jhenderson wrote:

> > Hello Davide,
> >  The present format is good enough to convey the information. It is however not sufficient or sometimes difficult for present users of GNU tools (which are quite ubiquitous) to make a
> >  switch as it is complete redesign of the post processing tools they may have based on.
> > 
> > -Hemant
>
> It's not immediately clear from the original introduction of GNU style whether complete output identity was the original goal, or just similarity. Similarly, it's not clear from my previously attempt to gather information as to users expectations. I've subscribed @khemant in case he's got any further comments, since he made the original change. My reading of rL260430 <https://reviews.llvm.org/rL260430> which commits it is that it is intended to be //like// GNU readelf, but doesn't necessarily have to be identical. I'm open to further discussion on this (and I actually have a BoF on this subject at the next Euro LLVM, but that's still a couple of months away).


@jhenderson Thanks for tracking down that comment.  I interpreted that comment as you described. Personally, I think a one line addition to the existing GNU style output is a reasonable change that will not detract users who might be expecting GNU-styled output.  The change provides the user with the familiar GNU style, and provides a one line bonus (it provides a complete table (all of the sections are accounted for)).  The main "issue" I  see is that anyone diffing llvm-readelf output against the equivalent GNU output will see a line difference (llvm-readelf has the Notes, GNU readelf does not).  If users diff output between llvm-readelf and GNU readelf, they would see other differences as well, primarily the number of digits used to represent some of the values in the `--program-headers` output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57700/new/

https://reviews.llvm.org/D57700





More information about the llvm-commits mailing list