[PATCH] D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 01:56:14 PST 2019


grimar added a comment.

In D57700#1384747 <https://reviews.llvm.org/D57700#1384747>, @jhenderson wrote:

> I'm happy with this, but since I was the one who suggested this offline, and I'm aware that there might be some reluctance to accept it from elsewhere, I'd like some other people's comments on it.


My main concern is: is it ok we change the GNU style output?

Actually, I am confused and wonder why we have LLVM and GNU styles first of all. 
I would understand if we would have GNU style that would try to be 1:1 to GNU and we would have LLVM style that would be an extension/restyling.

This patch changes GNU style of printSectionMapping. It makes me think we want LLVM style implementation of `printSectionMapping` instead maybe?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57700/new/

https://reviews.llvm.org/D57700





More information about the llvm-commits mailing list