[PATCH] D57544: [llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'

Fri Feb 1 01:57:25 PST 2019

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. The CHECK-NEXT can be in a follow-on, or just during the commit, assuming there's no issues.

================
Comment at: llvm/test/Object/nm-trivial-object.test:118-127
 ELF64-DEBUG-SYMS: 00000000 b .bss
+ELF64-DEBUG-SYMS: 00000000 n .comment
 ELF64-DEBUG-SYMS: 00000000 d .data
 ELF64-DEBUG-SYMS: 00000000 N .debug_abbrev
 ELF64-DEBUG-SYMS: 00000000 N .debug_aranges
 ELF64-DEBUG-SYMS: 00000000 N .debug_frame
 ELF64-DEBUG-SYMS: 00000000 N .debug_info
----------------
Could you use ELF64-DEBUG-SYMS-NEXT here to capture all the section names, and make sure there are no others we're missing?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57544/new/

https://reviews.llvm.org/D57544