[PATCH] D57544: [llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'

[Matt Davis via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL352891: [llvm-nm] Report '.comment' ELF sections as 'n' instead of '?' (authored by mattd, committed by ).
Herald added a project: LLVM.

Changed prior to commit:
  https://reviews.llvm.org/D57544?vs=184609&id=184773#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57544/new/

https://reviews.llvm.org/D57544

Files:
  llvm/trunk/test/Object/nm-trivial-object.test
  llvm/trunk/tools/llvm-nm/llvm-nm.cpp


Index: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
===================================================================
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp
@@ -935,6 +935,7 @@
     return StringSwitch<char>(*Name)
         .StartsWith(".debug", 'N')
         .StartsWith(".note", 'n')
+        .StartsWith(".comment", 'n')
         .Default('?');
   }
 
Index: llvm/trunk/test/Object/nm-trivial-object.test
===================================================================
--- llvm/trunk/test/Object/nm-trivial-object.test
+++ llvm/trunk/test/Object/nm-trivial-object.test
@@ -116,20 +116,21 @@
 ABSOLUTE-ELF64: 0000000000000123 A a2
 
 ELF64-DEBUG-SYMS: 00000000 b .bss
-ELF64-DEBUG-SYMS: 00000000 d .data
-ELF64-DEBUG-SYMS: 00000000 N .debug_abbrev
-ELF64-DEBUG-SYMS: 00000000 N .debug_aranges
-ELF64-DEBUG-SYMS: 00000000 N .debug_frame
-ELF64-DEBUG-SYMS: 00000000 N .debug_info
-ELF64-DEBUG-SYMS: 00000000 N .debug_line
-ELF64-DEBUG-SYMS: 00000000 N .debug_pubnames
-ELF64-DEBUG-SYMS: 00000000 n .note.GNU-stack
-ELF64-DEBUG-SYMS: 00000000 t .text
-ELF64-DEBUG-SYMS: 00000000 a IsNAN.cpp
-ELF64-DEBUG-SYMS: 00000014 T _ZN4llvm5IsNANEd
-ELF64-DEBUG-SYMS: 00000000 T _ZN4llvm5IsNANEf
-ELF64-DEBUG-SYMS:          U __isnan
-ELF64-DEBUG-SYMS:          U __isnanf
+ELF64-DEBUG-SYMS-NEXT: 00000000 n .comment
+ELF64-DEBUG-SYMS-NEXT: 00000000 d .data
+ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_abbrev
+ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_aranges
+ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_frame
+ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_info
+ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_line
+ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_pubnames
+ELF64-DEBUG-SYMS-NEXT: 00000000 n .note.GNU-stack
+ELF64-DEBUG-SYMS-NEXT: 00000000 t .text
+ELF64-DEBUG-SYMS-NEXT: 00000000 a IsNAN.cpp
+ELF64-DEBUG-SYMS-NEXT: 00000014 T _ZN4llvm5IsNANEd
+ELF64-DEBUG-SYMS-NEXT: 00000000 T _ZN4llvm5IsNANEf
+ELF64-DEBUG-SYMS-NEXT:          U __isnan
+ELF64-DEBUG-SYMS-NEXT:          U __isnanf
 
 macho:          U _SomeOtherFunction
 macho: 00000000 T _main


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57544.184773.patch
Type: text/x-patch
Size: 2072 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190201/7009f50f/attachment.bin>