[PATCH] D57544: [llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'

[Matt Davis via Phabricator via llvm-commits]

mattd created this revision.
mattd added a reviewer: jhenderson.
Herald added a subscriber: rupprecht.

The previous implementation reported `.comment` sections as '?'
 GNU uses 'n' which means  "The symbol is a debugging symbol."  `.note`  sections are represented as 'n' too.


https://reviews.llvm.org/D57544

Files:
  llvm/test/Object/nm-trivial-object.test
  llvm/tools/llvm-nm/llvm-nm.cpp


Index: llvm/tools/llvm-nm/llvm-nm.cpp
===================================================================
--- llvm/tools/llvm-nm/llvm-nm.cpp
+++ llvm/tools/llvm-nm/llvm-nm.cpp
@@ -935,6 +935,7 @@
     return StringSwitch<char>(*Name)
         .StartsWith(".debug", 'N')
         .StartsWith(".note", 'n')
+        .StartsWith(".comment", 'n')
         .Default('?');
   }
 
Index: llvm/test/Object/nm-trivial-object.test
===================================================================
--- llvm/test/Object/nm-trivial-object.test
+++ llvm/test/Object/nm-trivial-object.test
@@ -116,6 +116,7 @@
 ABSOLUTE-ELF64: 0000000000000123 A a2
 
 ELF64-DEBUG-SYMS: 00000000 b .bss
+ELF64-DEBUG-SYMS: 00000000 n .comment
 ELF64-DEBUG-SYMS: 00000000 d .data
 ELF64-DEBUG-SYMS: 00000000 N .debug_abbrev
 ELF64-DEBUG-SYMS: 00000000 N .debug_aranges


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57544.184609.patch
Type: text/x-patch
Size: 837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/46b93aa7/attachment.bin>