[PATCH] D55293: [LLD][COFF] Partial sections

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 12:43:53 PST 2019


aganea marked an inline comment as done.
aganea added inline comments.


================
Comment at: COFF/Writer.cpp:183
+  bool operator()(PartialSection *L, PartialSection *R) const {
+    return L && R && *L < *R;
+  }
----------------
ruiu wrote:
> Can this null condition happen?
No, it cannot. I can transform the null checks into an assert, if you’re fine with that? The intent will be better expressed.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55293/new/

https://reviews.llvm.org/D55293





More information about the llvm-commits mailing list