[PATCH] D55293: [LLD][COFF] Partial sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:167
+      : Name(N), Characteristics(Chars) {}
+  llvm::StringRef Name;
+  unsigned Characteristics;
----------------
Now you can refer this class as just `StringRef` instead of `llvm::StringRef`.


================
Comment at: COFF/Writer.cpp:183
+  bool operator()(PartialSection *L, PartialSection *R) const {
+    return L && R && *L < *R;
+  }
----------------
Can this null condition happen?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55293/new/

https://reviews.llvm.org/D55293