[PATCH] D55293: [LLD][COFF] Partial sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:183
+  bool operator()(PartialSection *L, PartialSection *R) const {
+    return L && R && *L < *R;
+  }
----------------
aganea wrote:
> ruiu wrote:
> > Can this null condition happen?
> No, it cannot. I can transform the null checks into an assert, if you’re fine with that? The intent will be better expressed.
I don't think you even have to have a null check. Dereferencing a pointer clearly delivers the intent that the pointer cannot be null.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55293/new/

https://reviews.llvm.org/D55293