[PATCH] D56954: hwasan: Move memory access checks into small outlined functions on aarch64.

Tue Jan 22 16:46:04 PST 2019

pcc marked an inline comment as done.
pcc added a comment.

In D56954#1367060 <https://reviews.llvm.org/D56954#1367060>, @eugenis wrote:

> More than half of this changelist is switching shadow addressing to getelementptr. Could you do it in a separate change?

I think I could, but it would make the tests (more) painful to update. I guess I could drop the tests for abort in basic.ll in the first change and then bring them back in the second change, if that's ok?

================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:281
+    OutStreamer->EmitSymbolAttribute(Sym, MCSA_ELF_TypeFunction);
+    OutStreamer->EmitSymbolAttribute(Sym, MCSA_Weak);
+    OutStreamer->EmitSymbolAttribute(Sym, MCSA_Hidden);
----------------
eugenis wrote:
> why weak?
Because we're not guaranteed that the linker will be able to resolve comdats at this point. LLD for example will ignore comdats in post-LTO object files (see discussion in D56015). On the other hand, weak/strong resolution will work fine.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56954/new/

https://reviews.llvm.org/D56954