[PATCH] D56954: hwasan: Move memory access checks into small outlined functions on aarch64.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 16:33:46 PST 2019


eugenis added a comment.

More than half of this changelist is switching shadow addressing to getelementptr. Could you do it in a separate change?



================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:281
+    OutStreamer->EmitSymbolAttribute(Sym, MCSA_ELF_TypeFunction);
+    OutStreamer->EmitSymbolAttribute(Sym, MCSA_Weak);
+    OutStreamer->EmitSymbolAttribute(Sym, MCSA_Hidden);
----------------
why weak?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56954/new/

https://reviews.llvm.org/D56954





More information about the llvm-commits mailing list