[PATCH] D56954: hwasan: Move memory access checks into small outlined functions on aarch64.

Tue Jan 22 17:10:24 PST 2019

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

> I think I could, but it would make the tests (more) painful to update. I guess I could drop the tests for abort in basic.ll in the first change and then bring them back in the second change, if that's ok?

Let's keep it as one change then.

================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterBankInfo.cpp:254
+  case AArch64::GPR64common_and_GPR64noipRegClassID:
+  case AArch64::GPR64noip_and_tcGPR64RegClassID:
   case AArch64::tcGPR64RegClassID:
----------------
These are weird. At least one of them goes away if GPR64noip is derived from GPR64common instead of GPR64.

================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:534
+
+  if (TargetTriple.isAArch64() && TargetTriple.isOSBinFormatELF() && !Recover) {
+    Module *M = IRB.GetInsertBlock()->getParent()->getParent();
----------------
Let's add an -mllvm flag to disable this feature, just in case.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56954/new/

https://reviews.llvm.org/D56954