[PATCH] D56799: [NFC] Factor out + document build requirements

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:11-12
+set(CLANG_WARN 3.1)
+set(APPLECLANG_MIN 3.1)
+set(APPLECLANG_WARN 3.1)
+set(MSVC_MIN 19.0)
----------------
Did you really mean these to be the same as CLANG_MIN and CLANG_WARN?


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:17
+function(check_compiler_version NAME NICE_NAME MINIMUM_VERSION WARN_VERSION)
+  if(CMAKE_CXX_COMPILER_ID STREQUAL NAME)
+    if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS MINIMUM_VERSION)
----------------
You could invert this condition and do an early return instead, which would reduce the remainder of the function by one indent level.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56799/new/

https://reviews.llvm.org/D56799