[PATCH] D56799: [NFC] Factor out + document build requirements

[JF Bastien via Phabricator via llvm-commits]

jfb marked 3 inline comments as done.
jfb added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:21
+    elseif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS WARN_VERSION)
+      message(WARNING "Host ${NICE_NAME} version must be at least ${WARN_VERSION} due to miscompiles from earlier versions, your version is ${CMAKE_CXX_COMPILER_VERSION}.")
+    endif()
----------------
mehdi_amini wrote:
> (I assume the message will be updated later)
That's my intent, yes. I'm trying to make the future diff smaller with this patch.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:61
     endif()
+
   endif()
----------------
mehdi_amini wrote:
> (spurious?)
I added it on purpose, it made the flow easier to read IMO. Not that CMake is ever easy or nice to read 😭


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56799/new/

https://reviews.llvm.org/D56799