[PATCH] D56799: [NFC] Factor out + document build requirements

Wed Jan 16 13:36:13 PST 2019

erichkeane added a comment.

I think this is a good start. That said, this is also a bug-fix (not exactly NFC), since it adds the Clang check to AppleClang.

================
Comment at: cmake/modules/CheckCompilerVersion.cmake:11-12
+set(CLANG_WARN 3.1)
+set(APPLECLANG_MIN 3.1)
+set(APPLECLANG_WARN 3.1)
+set(MSVC_MIN 19.0)
----------------
smeenai wrote:
> Did you really mean these to be the same as CLANG_MIN and CLANG_WARN?
According to this: https://gist.github.com/yamaya/2924292 those are the same versions.  AppleClang 3.1 IS Clang 3.1.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56799/new/

https://reviews.llvm.org/D56799