[PATCH] D56406: Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 09:56:10 PST 2019


rampitec added a comment.

In D56406#1349338 <https://reviews.llvm.org/D56406#1349338>, @craig.topper wrote:

> Doesn't SimplifyDemandedBits already call ShrinkDemandedConstant for AND/OR/XOR? And without an override of targetShrinkDemandedConstant, ShrinkDemandedConstant only works on those 3 nodes. So is an explicit call to ShrinkDemandedConstant even needed here?


Good point. Turns out I can simply drop it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56406/new/

https://reviews.llvm.org/D56406





More information about the llvm-commits mailing list